Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/squash bugs #1355

Merged
merged 6 commits into from
Aug 14, 2019
Merged

Bug/squash bugs #1355

merged 6 commits into from
Aug 14, 2019

Conversation

SteveMieskoski
Copy link
Contributor

@SteveMieskoski SteveMieskoski commented Aug 14, 2019

Bug

  • Updated CHANGELOG.md

  • Add PR label

  • fix broken changing address using mnemonic phrase

  • fix 404 when changing addresses

@SteveMieskoski SteveMieskoski added the Fixed Issue is fixed waiting for merge label Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #1355 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1355      +/-   ##
===========================================
+ Coverage    20.93%   20.94%   +<.01%     
===========================================
  Files          330      330              
  Lines         8797     8798       +1     
  Branches      1597     1598       +1     
===========================================
+ Hits          1842     1843       +1     
  Misses        6454     6454              
  Partials       501      501
Impacted Files Coverage Δ
src/layouts/InterfaceLayout/InterfaceLayout.vue 0% <ø> (ø) ⬆️
src/partners/changelly/changelly.js 2.1% <ø> (ø) ⬆️
src/partners/simplex/simplex.js 1.14% <ø> (ø) ⬆️
.../NetworkAndAddressModal/NetworkAndAddressModal.vue 26.66% <100%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0313549...d7d2d15. Read the comment docs.

@kvhnuke kvhnuke merged commit 88f7bf6 into develop Aug 14, 2019
@gamalielhere gamalielhere deleted the bug/squash_bugs branch August 14, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Issue is fixed waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants