Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/network-address-show-custom-first #1589

Merged
merged 2 commits into from
Nov 5, 2019
Merged

bug/network-address-show-custom-first #1589

merged 2 commits into from
Nov 5, 2019

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Oct 31, 2019
@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #1589 into develop will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1589      +/-   ##
===========================================
- Coverage    15.55%   15.54%   -0.01%     
===========================================
  Files          399      399              
  Lines        11650    11647       -3     
  Branches      2055     2053       -2     
===========================================
- Hits          1812     1811       -1     
+ Misses        9183     9181       -2     
  Partials       655      655
Impacted Files Coverage Δ
.../NetworkAndAddressModal/NetworkAndAddressModal.vue 24.17% <33.33%> (-0.3%) ⬇️
...ntainers/DashboardContainer/DashboardContainer.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a661da...7a533e8. Read the comment docs.

@gamalielhere gamalielhere merged commit fe29292 into develop Nov 5, 2019
@gamalielhere gamalielhere deleted the bug/network-address-show-custom-first branch November 5, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@gesseekur gesseekur gesseekur approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gamalielhere @kvhnuke @gesseekur @SteveMieskoski @mew-bot