Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/mewconnect path issue #1687

Merged
merged 7 commits into from
Dec 2, 2019
Merged

Bug/mewconnect path issue #1687

merged 7 commits into from
Dec 2, 2019

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Nov 27, 2019
@gamalielhere gamalielhere changed the base branch from master to develop November 27, 2019 01:37
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1687 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1687   +/-   ##
========================================
  Coverage    16.59%   16.59%           
========================================
  Files          396      396           
  Lines        12193    12193           
  Branches      2144     2144           
========================================
  Hits          2024     2024           
  Misses        9505     9505           
  Partials       664      664
Impacted Files Coverage Δ
...ntainers/ManageENSContainer/ManageENSContainer.vue 8.45% <ø> (ø) ⬆️
src/builds/configs/base-routes.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f83f0...8b41202. Read the comment docs.

@gamalielhere gamalielhere merged commit 2c0e4aa into develop Dec 2, 2019
@gamalielhere gamalielhere deleted the bug/mewconnect-path-issue branch December 2, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants