Feature/coolwallet [v5] #2087
Merged
Feature/coolwallet [v5] #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamalielhere
requested review from
gesseekur,
kvhnuke and
SteveMieskoski
as code owners
gamalielhere
added
Ready
gesseekur
approved these changes
Mar 12, 2020
kvhnuke
requested changes
Mar 20, 2020
src/layouts/AccessWalletLayout/components/HardwareModal/HardwareModal.vue
Show resolved
Hide resolved
src/layouts/AccessWalletLayout/components/HardwareModal/HardwareModal.vue
Outdated
Show resolved
Hide resolved
Comment on lines
+85
to
+87
| await cwsTransportLib.listen(async (error, device) => { | ||
| if (device) { | ||
| const transport = await cwsTransportLib.connect(device); |
There was a problem hiding this comment.
this should be moved inside the wallet init function? I think previous unlockWallet function should be sufficient
There was a problem hiding this comment.
moving it here fixed the scoping issue
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature