Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed cases for gas price too high #2544

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

SteveMieskoski
Copy link
Contributor

@SteveMieskoski SteveMieskoski commented Aug 14, 2020

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@SteveMieskoski SteveMieskoski added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5 labels Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #2544 into develop will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2544   +/-   ##
========================================
  Coverage    13.95%   13.95%           
========================================
  Files          470      470           
  Lines        18772    18768    -4     
  Branches      3214     3209    -5     
========================================
  Hits          2619     2619           
+ Misses       15310    15307    -3     
+ Partials       843      842    -1     
Impacted Files Coverage Δ
...eLayout/containers/SwapContainer/SwapContainer.vue 24.02% <0.00%> (-0.07%) ⬇️
src/partners/dexAg/dexAg.js 20.39% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aa251...629d733. Read the comment docs.

@SteveMieskoski SteveMieskoski changed the base branch from master to develop August 14, 2020 19:14
@gamalielhere gamalielhere merged commit 21917ed into develop Aug 19, 2020
@gamalielhere gamalielhere deleted the bug/fix-gas-price-too-high-check branch August 19, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants