Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent excessive polling #266

Merged
merged 6 commits into from
Dec 20, 2018
Merged

Conversation

kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Dec 12, 2018

currently web3 will poll eth_getTransactionReceipt every second after sending a tx. This PR will increase it to every 30 seconds to decrease unnecessary polling

Devop

  • Updated CHANGELOG.md
  • Add PR label

@kvhnuke kvhnuke added Devop Devop tasks Ready Tag for when a PR is ready to merge labels Dec 12, 2018
@kvhnuke kvhnuke added WIP work in proress and removed WIP work in proress labels Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #266 into develop will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
- Coverage    18.09%   18.02%   -0.08%     
===========================================
  Files          340      341       +1     
  Lines         4663     4683      +20     
  Branches       616      619       +3     
===========================================
  Hits           844      844              
- Misses        3520     3537      +17     
- Partials       299      302       +3
Impacted Files Coverage Δ
src/wallets/web3-provider/web3Calls.js 0% <ø> (ø) ⬆️
...lets/web3-provider/providers/etherscan-provider.js 0% <0%> (ø) ⬆️
.../wallets/web3-provider/providers/given-provider.js 0% <0%> (ø) ⬆️
src/wallets/web3-provider/methods/index.js 0% <0%> (ø) ⬆️
src/wallets/web3-provider/providers/ws-provider.js 0% <0%> (ø) ⬆️
...c/wallets/web3-provider/providers/http-provider.js 0% <0%> (ø) ⬆️
...llets/web3-provider/methods/eth_sendTransaction.js 0% <0%> (ø) ⬆️
...web3-provider/methods/eth_getTransactionReceipt.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0227c4c...4dfd185. Read the comment docs.

@gamalielhere gamalielhere merged commit 8ea659a into develop Dec 20, 2018
@gamalielhere gamalielhere deleted the devop/prevent-excessive-polling branch December 20, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devop Devop tasks Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants