Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devop/general-fixes #274

Merged
merged 21 commits into from
Dec 20, 2018
Merged

devop/general-fixes #274

merged 21 commits into from
Dec 20, 2018

Conversation

gamalielhere
Copy link
Contributor

Devop

  • Updated CHANGELOG.md
  • Add PR label

@gamalielhere gamalielhere added Devop Devop tasks WIP work in proress Ready Tag for when a PR is ready to merge and removed WIP work in proress labels Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #274 into develop will decrease coverage by 0.12%.
The diff coverage is 8.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    18.24%   18.12%   -0.13%     
===========================================
  Files          340      340              
  Lines         4604     4663      +59     
  Branches       611      616       +5     
===========================================
+ Hits           840      845       +5     
- Misses        3465     3519      +54     
  Partials       299      299
Impacted Files Coverage Δ
...t/components/InterfaceNetwork/InterfaceNetwork.vue 25% <ø> (ø) ⬆️
...tLayout/components/PasswordModal/PasswordModal.vue 0% <ø> (ø) ⬆️
.../ConfirmCollectionModal/ConfirmCollectionModal.vue 0% <ø> (ø) ⬆️
...ts/InterfaceNetworkModal/InterfaceNetworkModal.vue 9.75% <ø> (ø) ⬆️
src/dapps/BuySubdomain/BuySubdomain.vue 17.77% <ø> (ø) ⬆️
...tialENSStateContainer/InitialENSStateContainer.vue 28.57% <ø> (ø) ⬆️
...ners/SignMessageContainer/SignMessageContainer.vue 50% <ø> (ø) ⬆️
...Container/components/GenerateInfo/GenerateInfo.vue 23.07% <ø> (ø) ⬆️
...ccessMyWalletContainer/AccessMyWalletContainer.vue 0% <ø> (ø) ⬆️
...ontractContainer/InteractWithContractContainer.vue 20.54% <ø> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccbd41...be4bddc. Read the comment docs.

@gamalielhere gamalielhere added WIP work in proress and removed WIP work in proress labels Dec 20, 2018
@gamalielhere gamalielhere merged commit 0227c4c into develop Dec 20, 2018
@gamalielhere gamalielhere deleted the devop/general-fixes branch December 20, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devop Devop tasks Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants