DApp/ Schedule Transactions #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josipbagaric
changed the title
josipbagaric
changed the title
|
@kvhnuke @SteveMieskoski No longer a WIP. Ready to be reviewed! |
…ing-esn-icon add a missing ESN network icon
Adds RSK ledger dpaths
…llet into devop/misc-fixes
…erface-address-block Ui/update interface address block
…-tx-swap-success-modal Update success modal for transaction and swap
…ification-dot-animation Update notification dot animation
kvhnuke
requested changes
Feb 28, 2019
| ...mapGetters([ | ||
| 'web3', | ||
| 'network', | ||
| 'wallet', |
There was a problem hiding this comment.
can you remove the walletimport
… token symbol if exists
…contracts Turn addresses to lowercase to avoid issues with web3 in "Interact with contracts"
gamalielhere
reviewed
Mar 1, 2019
| selectedTimeZone: moment.tz.guess(), | ||
| selectedCurrency: '', | ||
| showTokenTransferNotification: true, | ||
| amountInputOptions() { |
There was a problem hiding this comment.
These functions that returns the options might be better suited in the computed property so whenever the this instances inside updates, it also updates instead of being called only once.
gamalielhere
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DApp: Schedule transactions
This DApp uses the Ethereum Alarm Clock protocol to schedule transactions for the future.
Screenshots