Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/fix logout warning modal #684

Merged
merged 17 commits into from
Feb 20, 2019
Merged

Dev/fix logout warning modal #684

merged 17 commits into from
Feb 20, 2019

Conversation

hsurf22
Copy link
Contributor

@hsurf22 hsurf22 commented Feb 20, 2019 •
edited
Loading

Bug

  • Updated CHANGELOG.md
  • Add PR label
    • Fix logout warning modal to show when user gets out of "Interface page"

screenshot from 2019-02-19 18-30-58

https://youtu.be/s3HjPfG8_Lg

@hsurf22 hsurf22 changed the title Dev/fix logout modal Dev/fix logout warning modal Feb 20, 2019
@hsurf22 hsurf22 added the Ready Tag for when a PR is ready to merge label Feb 20, 2019
@hsurf22 hsurf22 changed the base branch from master to develop February 20, 2019 02:32
@kvhnuke kvhnuke changed the base branch from develop to fix/sentry-errors-5.0.3 February 20, 2019 04:10
@kvhnuke kvhnuke merged commit 48197e2 into fix/sentry-errors-5.0.3 Feb 20, 2019
@kvhnuke kvhnuke deleted the dev/fix-logout-modal branch February 20, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsurf22 @mew-bot @kvhnuke @gamalielhere