This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
temporal fix to workaround EIP155 issue with chainid > 255 #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackmod
force-pushed
the
ledger-eip155-chainid255
branch
3 times, most recently
from
802fbfc
to
edebdc6
Compare
|
802fbfc commit does not work with web3 at all |
hackmod
force-pushed
the
ledger-eip155-chainid255
branch
from
1f95940
to
edebdc6
Compare
|
We can't allow this, this pretty much opens up replay attack, since it is no longer using EIP155 |
hackmod
force-pushed
the
ledger-eip155-chainid255
branch
from
edebdc6
to
49d5674
Compare
|
@gamalielhere // thank you for your reply. ClassicalEtherWallet already use similar method for their CLO ledger support. anyway, I've separated previous PR into two commit.
|
|
@hackmod ClassicEtherWallet decided to support Callisto Ledger patch for enabling their Callisto deposit. It is very dangerous for using the patch widely |
|
finally, the latest ledger support EIP155 + 32bits chainid. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also LedgerHQ/ledgerjs#168