Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactoring #81

wants to merge 2 commits into from

Conversation

Sonderful
Copy link
Contributor

  • DiscoveryActivity is unreachable for a normal user of the app. It seems to have been untouched for two years. Removing for now, easy to revive if someone still needs it.
  • Also removing the location permission that was required for beacons. Missed in previous commits.
  • Many dependencies were out of date, so I updated them.
  • Several dependencies were unused (palette library).
  • Unit test dependencies were JUnit 4, switched to JUnit 5 and MockK for Kotlin, instead of Mockito.
  • Removed Powermock, which was completely unnecessary for mocking the android.util.Log class.
  • Removed example unit test class.

Sonderful added 2 commits November 23, 2018 23:31
DiscoveryActivity is unreachable for a normal user of the app. It seems to have been untouched for two years. Removing for now, easy to revive if someone still needs it.
Also removing the location permission that was required for beacons. Missed in previous commits.
* Many dependencies were out of date, so I updated them.
* Several dependencies were unused (palette library).
* Unit test dependencies were JUnit 4, switched to JUnit 5 and MockK for Kotlin, instead of Mockito.
* Removed Powermock, which was completely unnecessary for mocking the android.util.Log class.
* Removed example unit test class.
@bd0n4lds
Copy link

bd0n4lds commented Jun 1, 2019

There is an Invalided context in activity_display.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
tools:context="mycroft.ai.wear.MycroftDisplayActivity"
tools:deviceIds="wear">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants