Upgrade versions of numpy e.a. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rogervankanten was there a reason for changing from EDIT: nevermind, saw that |
aikkala
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
@HuaweiWang Looks good to me, I think we could merge it. There are some warning messages displayed when generating the pdf (shown below), so we could sort them out before the merge if necessary. They come up when e.g. line 188 in generate_pdf.py is executed, but I'm not sure what exactly is the cause.
Ignoring unsupported SVG tag: <style> (contributions are welcome to add support for it)
Ignoring unsupported SVG tag: <metadata> (contributions are welcome to add support for it)
Ignoring unsupported SVG tag: <style> (contributions are welcome to add support for it)
|
This warning comes from the fpdf2 package that we are using. And it is a known limitation. We probably cannot do much about it. @rogervankanten Thanks for upgrating the Numpy version. @aikkala Thanks for checking. Will merge this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade versions of several packages, including numpy (1.23.5).