Skip to content

Commit

Permalink
fixup: Add TODOs for bugfixes
Browse files Browse the repository at this point in the history
  • Loading branch information
amnn committed Apr 29, 2024
1 parent 83bb808 commit 1b8d312
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/sui-graphql-rpc/src/types/dynamic_field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ impl DynamicField {
ctx,
self.df_object_id,
Object::under_parent(
// TODO (RPC-131): The dynamic object field value's version should be bounded by
// the field's parent version, not the version of the field object itself.
self.super_.super_.version_impl(),
self.super_.super_.checkpoint_viewed_at,
),
Expand Down
1 change: 1 addition & 0 deletions crates/sui-graphql-rpc/src/types/object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,7 @@ fn objects_query(filter: &ObjectFilter, range: AvailableRange, page: &Page<Curso
where
{
let view = if filter.object_keys.is_some() || !filter.has_filters() {
// TODO (RPC-142): Fix handling of filters that contain both object keys and object ids.
View::Historical
} else {
View::Consistent
Expand Down

0 comments on commit 1b8d312

Please sign in to comment.