[move] Update error behavior on serialization boundaries (#19064)

## Description 

Update the semantics around serialization errors when computing type
layouts to follow the underlying layout errors more closely.

## Test plan 

Manually tested.

crates/sui-open-rpc/spec/openrpc.json

@@ -1341,6 +1341,7 @@
                 "reject_mutable_random_on_entry_functions": false,
                 "reshare_at_same_initial_version": false,
                 "resolve_abort_locations_to_package_id": false,
+                "rethrow_serialization_type_layout_errors": false,
                 "scoring_decision_with_validity_cutoff": true,
                 "shared_object_deletion": false,
                 "simple_conservation_checks": false,

crates/sui-protocol-config/src/lib.rs

@@ -168,6 +168,7 @@ const MAX_PROTOCOL_VERSION: u64 = 55;
 // Version 54: Enable random beacon on mainnet.
 //             Enable soft bundle on mainnet.
 // Version 55: Enable enums on mainnet.
+//             Rethrow serialization type layout errors instead of converting them.
 
 #[derive(Copy, Clone, Debug, Hash, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ProtocolVersion(u64);
@@ -506,6 +507,10 @@ struct FeatureFlags {
     // Use AuthorityCapabilitiesV2
     #[serde(skip_serializing_if = "is_false")]
     authority_capabilities_v2: bool,
+
+    // Rethrow type layout errors during serialization instead of trying to convert them.
+    #[serde(skip_serializing_if = "is_false")]
+    rethrow_serialization_type_layout_errors: bool,
 }
 
 fn is_false(b: &bool) -> bool {
@@ -1536,6 +1541,10 @@ impl ProtocolConfig {
         // 500 is the value used before this field is introduced.
         self.consensus_max_num_transactions_in_block.unwrap_or(500)
     }
+
+    pub fn rethrow_serialization_type_layout_errors(&self) -> bool {
+        self.feature_flags.rethrow_serialization_type_layout_errors
+    }
 }
 
 #[cfg(not(msim))]
@@ -2671,6 +2680,8 @@ impl ProtocolConfig {
                     // Assume 20_000 TPS * 5% max stake per validator / (minimum) 4 blocks per round = 250 transactions per block maximum
                     // Using a higher limit that is 512, to account for bursty traffic and system transactions.
                     cfg.consensus_max_num_transactions_in_block = Some(512);
+
+                    cfg.feature_flags.rethrow_serialization_type_layout_errors = true;
                 }
                 // Use this template when making changes:
                 //

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_55.snap

@@ -58,6 +58,7 @@ feature_flags:
   mysticeti_num_leaders_per_round: 1
   soft_bundle: true
   enable_coin_deny_list_v2: true
+  rethrow_serialization_type_layout_errors: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000
@@ -319,3 +320,4 @@ checkpoint_summary_version_specific_data: 1
 max_soft_bundle_size: 5
 bridge_should_try_to_finalize_committee: false
 max_accumulated_txn_cost_per_object_in_mysticeti_commit: 10
+

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_55.snap

@@ -59,6 +59,7 @@ feature_flags:
   mysticeti_num_leaders_per_round: 1
   soft_bundle: true
   enable_coin_deny_list_v2: true
+  rethrow_serialization_type_layout_errors: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000
@@ -320,3 +321,4 @@ checkpoint_summary_version_specific_data: 1
 max_soft_bundle_size: 5
 bridge_should_try_to_finalize_committee: true
 max_accumulated_txn_cost_per_object_in_mysticeti_commit: 10
+

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_55.snap

@@ -64,6 +64,7 @@ feature_flags:
   enable_coin_deny_list_v2: true
   passkey_auth: true
   authority_capabilities_v2: true
+  rethrow_serialization_type_layout_errors: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000
@@ -329,3 +330,4 @@ checkpoint_summary_version_specific_data: 1
 max_soft_bundle_size: 5
 bridge_should_try_to_finalize_committee: true
 max_accumulated_txn_cost_per_object_in_mysticeti_commit: 10
+

external-crates/move/crates/move-vm-config/src/runtime.rs

@@ -33,6 +33,9 @@ pub struct VMConfig {
     pub error_execution_state: bool,
     // configuration for binary deserialization (modules)
     pub binary_config: BinaryConfig,
+    // Whether value serialization errors when generating type layouts should be rethrown or
+    // converted to a different error.
+    pub rethrow_serialization_type_layout_errors: bool,
 }
 
 impl Default for VMConfig {
@@ -46,6 +49,7 @@ impl Default for VMConfig {
             profiler_config: None,
             error_execution_state: true,
             binary_config: BinaryConfig::with_extraneous_bytes_check(false),
+            rethrow_serialization_type_layout_errors: false,
         }
     }
 }

external-crates/move/crates/move-vm-runtime/src/runtime.rs

@@ -265,11 +265,20 @@ impl VMRuntime {
             _ => (ty, value),
         };
 
-        let layout = self.loader.type_to_type_layout(ty).map_err(|_err| {
-            PartialVMError::new(StatusCode::VERIFICATION_ERROR).with_message(
-                "entry point functions cannot have non-serializable return types".to_string(),
-            )
-        })?;
+        let layout = if self
+            .loader()
+            .vm_config()
+            .rethrow_serialization_type_layout_errors
+        {
+            self.loader.type_to_type_layout(ty)?
+        } else {
+            self.loader.type_to_type_layout(ty).map_err(|_err| {
+                PartialVMError::new(StatusCode::VERIFICATION_ERROR).with_message(
+                    "entry point functions cannot have non-serializable return types".to_string(),
+                )
+            })?
+        };
+
         let bytes = value.simple_serialize(&layout).ok_or_else(|| {
             PartialVMError::new(StatusCode::UNKNOWN_INVARIANT_VIOLATION_ERROR)
                 .with_message("failed to serialize return values".to_string())

sui-execution/latest/sui-adapter/src/adapter.rs

@@ -70,6 +70,8 @@ mod checked {
                 // Don't augment errors with execution state on-chain
                 error_execution_state: false,
                 binary_config: to_binary_config(protocol_config),
+                rethrow_serialization_type_layout_errors: protocol_config
+                    .rethrow_serialization_type_layout_errors(),
             },
         )
         .map_err(|_| SuiError::ExecutionInvariantViolation)

sui-execution/v0/sui-adapter/src/adapter.rs

@@ -72,6 +72,8 @@ mod checked {
 
                 profiler_config: vm_profiler_config,
                 binary_config: to_binary_config(protocol_config),
+                rethrow_serialization_type_layout_errors: protocol_config
+                    .rethrow_serialization_type_layout_errors(),
             },
         )
         .map_err(|_| SuiError::ExecutionInvariantViolation)

sui-execution/v1/sui-adapter/src/adapter.rs

@@ -72,6 +72,8 @@ mod checked {
                 // Don't augment errors with execution state on-chain
                 error_execution_state: false,
                 binary_config: to_binary_config(protocol_config),
+                rethrow_serialization_type_layout_errors: protocol_config
+                    .rethrow_serialization_type_layout_errors(),
             },
         )
         .map_err(|_| SuiError::ExecutionInvariantViolation)

sui-execution/v2/sui-adapter/src/adapter.rs

@@ -70,6 +70,8 @@ mod checked {
                 // Don't augment errors with execution state on-chain
                 error_execution_state: false,
                 binary_config: to_binary_config(protocol_config),
+                rethrow_serialization_type_layout_errors: protocol_config
+                    .rethrow_serialization_type_layout_errors(),
             },
         )
         .map_err(|_| SuiError::ExecutionInvariantViolation)