Upgrade mechanism improvement (#17049)

MystenLabs · May 9, 2024 · 52c2db9 · 52c2db9
1 parent a728cde
commit 52c2db9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/bridge/evm/contracts/utils/CommitteeUpgradeable.sol b/bridge/evm/contracts/utils/CommitteeUpgradeable.sol
@@ -51,16 +51,15 @@ abstract contract CommitteeUpgradeable is
         _upgradeAuthorized = true;
         // upgrade contract
         upgradeToAndCall(implementation, callData); // Upgraded event emitted with new implementation address
-        // reset upgrade authorization
-        _upgradeAuthorized = false;
     }
 
     /* ========== INTERNAL FUNCTIONS ========== */
 
     /// @notice Authorizes the upgrade of the inheriting contract.
     /// @dev The _upgradeAuthorized state variable can only be set with the upgradeWithSignatures
     /// function, meaning that the upgrade can only be authorized by the committee.
-    function _authorizeUpgrade(address) internal view override {
+    function _authorizeUpgrade(address) internal override {
         require(_upgradeAuthorized, "CommitteeUpgradeable: Unauthorized upgrade");
+        _upgradeAuthorized = false;
     }
 }