Skip to content

Commit

Permalink
fixup after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickkuo committed Mar 7, 2024
1 parent 4518d03 commit a78cee2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 15 deletions.
5 changes: 2 additions & 3 deletions crates/sui-bridge/src/sui_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ use crate::crypto::BridgeAuthorityPublicKey;
use crate::error::{BridgeError, BridgeResult};
use crate::events::SuiBridgeEvent;
use crate::retry_with_max_elapsed_time;
use crate::sui_transaction_builder::get_bridge_package_id;
use crate::types::BridgeActionStatus;
use crate::types::{BridgeAction, BridgeAuthority, BridgeCommittee};

Expand Down Expand Up @@ -202,8 +201,8 @@ where
action: &BridgeAction,
) -> BridgeActionStatus {
loop {
let Ok(bridge_records_id) =
retry_with_max_delay!(self.get_bridge_record_id(), Duration::from_secs(600))
let Ok(Ok(bridge_records_id)) =
retry_with_max_elapsed_time!(self.get_bridge_record_id(), Duration::from_secs(30))
else {
// TODO: add metrics and fire alert
error!("Failed to get bridge records id");
Expand Down
5 changes: 5 additions & 0 deletions crates/sui-core/src/execution_cache/writeback_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ use sui_macros::fail_point_async;
use sui_protocol_config::ProtocolVersion;
use sui_types::accumulator::Accumulator;
use sui_types::base_types::{EpochId, ObjectID, ObjectRef, SequenceNumber, VerifiedExecutionData};
use sui_types::bridge::Bridge;
use sui_types::digests::{
ObjectDigest, TransactionDigest, TransactionEffectsDigest, TransactionEventsDigest,
};
Expand Down Expand Up @@ -1035,6 +1036,10 @@ impl ExecutionCacheRead for WritebackCache {
fn check_owned_object_locks_exist(&self, _owned_object_refs: &[ObjectRef]) -> SuiResult {
todo!()
}

fn get_bridge_object_unsafe(&self) -> SuiResult<Bridge> {
todo!()
}
}

impl ExecutionCacheWrite for WritebackCache {
Expand Down
10 changes: 0 additions & 10 deletions crates/sui-framework-snapshot/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -302,15 +302,5 @@
"0x0000000000000000000000000000000000000000000000000000000000000003",
"0x000000000000000000000000000000000000000000000000000000000000dee9"
]
},
"37": {
"git_revision": "55cf7b402c",
"package_ids": [
"0x0000000000000000000000000000000000000000000000000000000000000001",
"0x0000000000000000000000000000000000000000000000000000000000000002",
"0x0000000000000000000000000000000000000000000000000000000000000003",
"0x000000000000000000000000000000000000000000000000000000000000dee9",
"0x000000000000000000000000000000000000000000000000000000000000000b"
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,11 @@
// First <b>update</b> should be for round zero.
<b>assert</b>!(new_round == 0, <a href="../../dependencies/sui-framework/random.md#0x2_random_EInvalidRandomnessUpdate">EInvalidRandomnessUpdate</a>);
} <b>else</b> {
// Subsequent updates should increment either epoch or randomness_round.
// Subsequent updates should either increase epoch or increment randomness_round.
// Note that epoch may increase by more than 1 <b>if</b> an epoch is completed without
// randomness ever being generated in that epoch.
<b>assert</b>!(
(epoch == inner.epoch + 1 && new_round == 0) ||
(epoch &gt; inner.epoch && new_round == 0) ||
(new_round == inner.randomness_round + 1),
<a href="../../dependencies/sui-framework/random.md#0x2_random_EInvalidRandomnessUpdate">EInvalidRandomnessUpdate</a>
);
Expand Down

0 comments on commit a78cee2

Please sign in to comment.