Skip to content

Commit

Permalink
[bridge 71] remove stale comments (#17162)
Browse files Browse the repository at this point in the history
## Description 

Removed inaccurate comments. They were correct until we changed the type
of watermark.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
  • Loading branch information
longbowlu authored and patrickkuo committed May 9, 2024
1 parent 53d644d commit c541f61
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions crates/sui-bridge/src/sui_syncer.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0

//! The SuiSyncer module is responsible for synchronizing Events emitted on Sui blockchain from
//! concerned bridge packages.
//! The SuiSyncer module is responsible for synchronizing Events emitted
//! on Sui blockchain from concerned modules of bridge package 0x9.

use crate::{
error::BridgeResult,
Expand All @@ -19,8 +19,6 @@ use tokio::{
time::{self, Duration},
};

// TODO: use the right package id
// const PACKAGE_ID: ObjectID = SUI_SYSTEM_PACKAGE_ID;
const SUI_EVENTS_CHANNEL_SIZE: usize = 1000;

/// Map from contract address to their start cursor (exclusive)
Expand Down Expand Up @@ -100,10 +98,6 @@ where

let len = events.data.len();
if len != 0 {
// Note: it's extremely critical to make sure the SuiEvents we send via this channel
// are complete per transaction level. Namely, we should never send a partial list
// of events for a transaction. Otherwise, we may end up missing events.
// See `sui_client.query_events_by_module` for how this is implemented.
events_sender
.send((module.clone(), events.data))
.await
Expand Down

0 comments on commit c541f61

Please sign in to comment.