Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk, sui.js] Patches the response so it matches the RPC definition #12249

Merged
merged 1 commit into from
May 30, 2023

Conversation

damirka
Copy link
Contributor

@damirka damirka commented May 30, 2023

Description

Matches the RPC definition when "withBcs" is used.

Test Plan

Manually verified this dependency against RPC.


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

  • sui.js now has correct response type definition for the RPC "withBcs" call

@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview May 30, 2023 11:34am
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 11:34am
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 11:34am
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 11:34am
wallet-adapter ✅ Ready (Inspect) Visit Preview May 30, 2023 11:34am

@damirka damirka merged commit bcbb178 into main May 30, 2023
@damirka damirka deleted the ds/sdk-fix-incompat branch May 30, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants