Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deepbook] Cherrypick Introduce new module of clob and custodian (#12359) #12444

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

amnn
Copy link
Member

@amnn amnn commented Jun 12, 2023

Description

Add client-defined order id to the fields of order Add original_quantity to the fields of order to record initial quantity of order Add owner address to fileds of account_cap to enable parallel use of funds Minor adjustment to query api
Abort create_account and create_pool in module clob

Test Plan

cd to deepbook dir and run "sui move test"


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Introduce new modules: clob_v2 and custodian_v2 and deprecate clob and custodian.

@amnn amnn requested review from sblackshear and ebmifa June 12, 2023 16:03
@amnn amnn self-assigned this Jun 12, 2023
@amnn amnn requested a review from ronny-mysten as a code owner June 12, 2023 16:03
@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 7:31pm
sui-kiosk ❌ Failed (Inspect) Jun 12, 2023 7:31pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jun 12, 2023 7:31pm
explorer-storybook ⬜️ Ignored (Inspect) Jun 12, 2023 7:31pm
sui-wallet-kit ⬜️ Ignored (Inspect) Jun 12, 2023 7:31pm
wallet-adapter ⬜️ Ignored (Inspect) Jun 12, 2023 7:31pm

wiggins-dev and others added 4 commits June 12, 2023 20:30
Carve out protocol config 13 for these framework changes and re-generate
snapshot tests on release branch.

Test Plan:

```
sui$ cargo nextest run -p sui-protocol-config
sui$ cargo nextest run -p sui-swarm-config
```
@amnn amnn merged commit 1c8a20d into releases/sui-v1.3.0-release Jun 12, 2023
@amnn amnn deleted the amnn/pick-12359 branch June 12, 2023 20:01
ebmifa added a commit that referenced this pull request Jun 15, 2023
## Description 
Release Notes PR checker and generator

## Test Plan
```
eugene@mac-studio ~/code/sui (eugene/create_release_notes_workflow) $ ./scripts/generate-release-notes.sh releases/sui-v1.3.0-release releases/sui-v1.2.0-release
#12359:
#12444:

Introduce new modules: `clob_v2` and `custodian_v2` and deprecate `clob` and `custodian`.
#12231:
Adds the checkpoint low watermark for state sync. This lets a node to know who to query checkpoint contents according to the watermarks, once checkpoint pruning is enabled.
#12321:
#12251:
#12092:

Added a version of stake withdraw function that returns the withdrawn SUI tokens, for better composability.
#12258:
#12171:
update anemo to MystenLabs/anemo@1bfa784 which includes the `alternate_server_name` change. Set primary server name as `sui-{chain-id}`.  Note that if node starts to run this version in testnet/mainnet before the update is officially rolled out, it's likely the node won't be able to state sync.
#12043:

- adds `sui::kiosk::default()` function for easy Kiosk setup
```
Will test the workflows once this PR lands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants