Add RandomGenerator to Sui Framework #15019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All the interfaces are in. I didn't complete the tests yet but wanted to receive the first round of feedbacks before I add snapshots, etc. @dariorussi , please let me know if the design makes sense, and whether any of the functions better be implemented as native ones. @kchalkias , @aschran - CCed in case you have comments as well. |
aschran
reviewed
Nov 24, 2023
crates/sui-framework/packages/sui-framework/sources/random.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/random.move
Outdated
Show resolved
Hide resolved
amnn
reviewed
Nov 24, 2023
crates/sui-framework/packages/sui-framework/sources/random.move
Outdated
Show resolved
Hide resolved
dariorussi
reviewed
Nov 24, 2023
There was a problem hiding this comment.
it looks pretty good to me and let's see what others have to say.
I will come back after we gave more people a chance to review and considering it does not have high pri (having to wait for the PR from @aschran if I got it right)
crates/sui-framework/packages/sui-framework/sources/random.move
Outdated
Show resolved
Hide resolved
crates/sui-framework/packages/sui-framework/sources/random.move
Outdated
Show resolved
Hide resolved
aschran
approved these changes
Mar 21, 2024
leecchh
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Description Add interfaces for fetching randomness: `RandomGenerator` is a PRG with a seed that is derived from the global randomness (which is the same between randomness rounds) and a fresh UID (which is guaranteed to be unique by the framework). In other words, the seed is unpredictable without knowing the global randomness, and different for each created generator (thus not predictable even by different functions invoked for the same tx). `RandomGenerator` manages an internal state with a buffer of random bytes derived using the PRG, and provides high level functions for deriving integers from those random bytes. ## Test Plan Unit tests --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [x] breaking change for FNs (FN binary must upgrade) - [x] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Add Move interfaces for generating secure random values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add interfaces for fetching randomness:
RandomGeneratoris a PRG with a seed that is derived from the global randomness (which is the same between randomness rounds) and a fresh UID (which is guaranteed to be unique by the framework). In other words, the seed is unpredictable without knowing the global randomness, and different for each created generator (thus not predictable even by different functions invoked for the same tx).RandomGeneratormanages an internal state with a buffer of random bytes derived using the PRG, and provides high level functions for deriving integers from those random bytes.Test Plan
Unit tests
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Add Move interfaces for generating secure random values.
RandomGeneratoris a PRG with a seed that is derived from the global randomness (which is the same between randomness rounds) and a fresh UID (which is guaranteed to be unique by the framework).