[Native bridge move] tests for msg encoding and some changes #16216

longbowlu · 2024-02-13T02:06:56Z

Description

add msg encoding regression tests for Move using bytes generated in Rust
add assert_valid_chain_id and call it in all places where the value could come from unverified user input
other cosmetic changes

Test Plan

How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.

Type of Change (Check all that apply)

protocol change
user-visible impact
breaking change for a client SDKs
breaking change for FNs (FN binary must upgrade)
breaking change for validators or node operators (must upgrade binaries)
breaking change for on-chain data layout
necessitate either a data wipe or data migration

Release notes

vercel · 2024-02-13T02:07:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mysten-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2024 10:34am
sui-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2024 10:34am
sui-typescript-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2024 10:34am

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
explorer	⬜️ Ignored (Inspect)	Visit Preview	Feb 26, 2024 10:34am
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview	Feb 26, 2024 10:34am
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview	Feb 26, 2024 10:34am

crates/sui-framework/packages/bridge/sources/chain_ids.move

dariorussi

it looks good to me, can we look at the one comment and reply?
thanks so much

manolisliolios · 2024-02-21T13:26:37Z

crates/sui-framework/packages/bridge/sources/message.move

@@ -191,6 +204,10 @@ module bridge::message {
        token_type: u8,
        amount: u64
    ): BridgeMessage {


Shouldn't we also validate that the route is valid when creating these msgs?

this is just a constructor function for the BridgeMessage struct so not doing any checks here, the message won't be able to get any signature from the validators if the route is invalid anyway, so won't do any harm to the bridge

## Description Describe the changes or additions included in this PR. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: patrick <[email protected]>

longbowlu requested review from patrickkuo and dariorussi February 13, 2024 02:06

vercel bot deployed to Preview – sui-core February 13, 2024 02:07 View deployment

longbowlu force-pushed the lu/move-msg-regression-test branch from a7588b8 to 95696e3 Compare February 13, 2024 08:15

longbowlu requested a review from ronny-mysten as a code owner February 13, 2024 08:15

vercel bot deployed to Preview – sui-typescript-docs February 13, 2024 08:16 View deployment

vercel bot deployed to Preview – mysten-ui February 13, 2024 08:17 View deployment

vercel bot deployed to Preview – sui-core February 13, 2024 08:17 View deployment

longbowlu force-pushed the lu/move-bridge-limiter branch from 0a2e950 to f592dbb Compare February 14, 2024 00:20

longbowlu requested review from amnn, wlmyng, stefan-mysten, emmazzz, suiwombat and mystenmark as code owners February 14, 2024 00:20

longbowlu force-pushed the lu/move-msg-regression-test branch from 95696e3 to d08934e Compare February 14, 2024 00:47

vercel bot deployed to Preview – sui-typescript-docs February 14, 2024 00:48 View deployment

vercel bot deployed to Preview – mysten-ui February 14, 2024 00:48 View deployment

vercel bot deployed to Preview – sui-core February 14, 2024 00:49 View deployment

patrickkuo force-pushed the lu/move-bridge-limiter branch from f592dbb to ef8a214 Compare February 16, 2024 14:31

patrickkuo force-pushed the lu/move-msg-regression-test branch from d08934e to 369f43a Compare February 16, 2024 14:51

vercel bot deployed to Preview – sui-typescript-docs February 16, 2024 14:52 View deployment

vercel bot deployed to Preview – mysten-ui February 16, 2024 14:52 View deployment

vercel bot deployed to Preview – sui-core February 16, 2024 14:53 View deployment

tzakian reviewed Feb 21, 2024

View reviewed changes

crates/sui-framework/packages/bridge/sources/chain_ids.move Outdated Show resolved Hide resolved

dariorussi approved these changes Feb 21, 2024

View reviewed changes

manolisliolios reviewed Feb 21, 2024

View reviewed changes

patrickkuo force-pushed the lu/move-bridge-limiter branch from ef8a214 to 316f23b Compare February 22, 2024 14:50

patrickkuo force-pushed the lu/move-msg-regression-test branch from 369f43a to 479bd95 Compare February 22, 2024 18:28

vercel bot deployed to Preview – mysten-ui February 26, 2024 09:40 View deployment

vercel bot deployed to Preview – sui-core February 26, 2024 09:40 View deployment

patrickkuo force-pushed the lu/move-msg-regression-test branch from 74e0904 to c33b058 Compare February 26, 2024 10:18

vercel bot deployed to Preview – mysten-ui February 26, 2024 10:20 View deployment

vercel bot deployed to Preview – sui-typescript-docs February 26, 2024 10:20 View deployment

vercel bot deployed to Preview – sui-core February 26, 2024 10:21 View deployment

patrickkuo force-pushed the lu/move-msg-regression-test branch from c33b058 to c17b4c8 Compare February 26, 2024 10:30

vercel bot deployed to Preview – sui-typescript-docs February 26, 2024 10:31 View deployment

vercel bot deployed to Preview – mysten-ui February 26, 2024 10:31 View deployment

vercel bot deployed to Preview – sui-core February 26, 2024 10:31 View deployment

longbowlu and others added 2 commits February 26, 2024 10:31

[Native bridge move] tests for msg encoding and some changes (#16216)

aba42c5

patrickkuo force-pushed the lu/move-msg-regression-test branch from c17b4c8 to 4d71b18 Compare February 26, 2024 10:32

patrickkuo merged commit 6d68939 into feature/native-bridge Feb 26, 2024
32 of 38 checks passed

patrickkuo deleted the lu/move-msg-regression-test branch February 26, 2024 10:33

patrickkuo pushed a commit that referenced this pull request Feb 26, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

7de8446

vercel bot deployed to Preview – sui-typescript-docs February 26, 2024 10:33 View deployment

vercel bot deployed to Preview – mysten-ui February 26, 2024 10:34 View deployment

vercel bot deployed to Preview – sui-core February 26, 2024 10:34 View deployment

patrickkuo pushed a commit that referenced this pull request Mar 5, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

382b40e

patrickkuo pushed a commit that referenced this pull request Mar 7, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

14d6211

patrickkuo pushed a commit that referenced this pull request Mar 19, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

7381501

patrickkuo pushed a commit that referenced this pull request Mar 22, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

414bb94

patrickkuo pushed a commit that referenced this pull request Mar 26, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

e424dbb

patrickkuo pushed a commit that referenced this pull request May 2, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

467cc5a

patrickkuo pushed a commit that referenced this pull request May 8, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

3ba30a7

patrickkuo pushed a commit that referenced this pull request May 9, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

ad0b4ef

patrickkuo pushed a commit that referenced this pull request May 9, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

51618f5

patrickkuo pushed a commit that referenced this pull request May 9, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

8520dbb

patrickkuo pushed a commit that referenced this pull request May 9, 2024

[Native bridge move] tests for msg encoding and some changes (#16216)

f63016a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Native bridge move] tests for msg encoding and some changes #16216

[Native bridge move] tests for msg encoding and some changes #16216

longbowlu commented Feb 13, 2024

vercel bot commented Feb 13, 2024 •

edited

Loading

dariorussi left a comment

manolisliolios Feb 21, 2024

patrickkuo Feb 23, 2024

[Native bridge move] tests for msg encoding and some changes #16216

[Native bridge move] tests for msg encoding and some changes #16216

Conversation

longbowlu commented Feb 13, 2024

Description

Test Plan

Type of Change (Check all that apply)

Release notes

vercel bot commented Feb 13, 2024 • edited Loading

dariorussi left a comment

Choose a reason for hiding this comment

manolisliolios Feb 21, 2024

Choose a reason for hiding this comment

patrickkuo Feb 23, 2024

Choose a reason for hiding this comment

vercel bot commented Feb 13, 2024 •

edited

Loading