[move-2024] Method syntax for sui-framework
#16754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cgswords
changed the title
cgswords
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
ronny-mysten
as code owners
cgswords
changed the title
sui-framework
cgswords
force-pushed
the
cgswords/sui-framework-method-syntax
branch
from
f410512
to
2a7ab70
Compare
cgswords
force-pushed
the
cgswords/sui-framework-method-syntax
branch
from
2a7ab70
to
04b03e8
Compare
cgswords
force-pushed
the
cgswords/sui-framework-method-syntax
branch
from
3169c57
to
ff7fa0c
Compare
emmazzz
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Description Stacked on #16466 (and also #16634 as a result) This translates `sui-framework` to Move 2024. Public use funs: ``` sources/balance.move 10: public use fun sui::coin::from_balance as Balance.into_coin; sources/kiosk/kiosk.move 97: public use fun kiosk_owner_cap_for as KioskOwnerCap.kiosk; sources/coin.move 16: public use fun sui::pay::split_vec as Coin.split_vec; 19: public use fun sui::pay::join_vec as Coin.join_vec; 22: public use fun sui::pay::split_and_transfer as Coin.split_and_transfer; 25: public use fun sui::pay::divide_and_keep as Coin.divide_and_keep; sources/object.move 19: public use fun id_to_address as ID.to_address; 22: public use fun id_to_bytes as ID.to_bytes; 25: public use fun uid_as_inner as UID.as_inner; 28: public use fun uid_to_inner as UID.to_inner; 31: public use fun uid_to_address as UID.to_address; 34: public use fun uid_to_bytes as UID.to_bytes; sources/address.move 12: public use fun sui::object::id_from_address as address.to_id; ``` ## Test Plan Tests are unchanged. Note that many of the tests may be rewritten to also use method syntax, but this change is already large enough that it seemed prudent to do the tests in a separate diff. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: Todd Nowacki <[email protected]>
leecchh
pushed a commit
that referenced
this pull request
Mar 27, 2024
Stacked on #16466 (and also #16634 as a result) This translates `sui-framework` to Move 2024. Public use funs: ``` sources/balance.move 10: public use fun sui::coin::from_balance as Balance.into_coin; sources/kiosk/kiosk.move 97: public use fun kiosk_owner_cap_for as KioskOwnerCap.kiosk; sources/coin.move 16: public use fun sui::pay::split_vec as Coin.split_vec; 19: public use fun sui::pay::join_vec as Coin.join_vec; 22: public use fun sui::pay::split_and_transfer as Coin.split_and_transfer; 25: public use fun sui::pay::divide_and_keep as Coin.divide_and_keep; sources/object.move 19: public use fun id_to_address as ID.to_address; 22: public use fun id_to_bytes as ID.to_bytes; 25: public use fun uid_as_inner as UID.as_inner; 28: public use fun uid_to_inner as UID.to_inner; 31: public use fun uid_to_address as UID.to_address; 34: public use fun uid_to_bytes as UID.to_bytes; sources/address.move 12: public use fun sui::object::id_from_address as address.to_id; ``` Tests are unchanged. Note that many of the tests may be rewritten to also use method syntax, but this change is already large enough that it seemed prudent to do the tests in a separate diff. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration --------- Co-authored-by: Todd Nowacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #16466 (and also #16634 as a result)
This translates
sui-frameworkto Move 2024.Public use funs:
Should we consider
public use funsome of the definitions inpayforcoin?Test Plan
Tests are unchanged. Note that many of the tests may be rewritten to also use method syntax, but this change is already large enough that it seemed prudent to do the tests in a separate diff.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes