[bridge 62/n] make bridge_client_gas_object optional, add tests for starting bridge node
#16771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
longbowlu
changed the title
bridge_client_gas_object optional, add tests for starting bridge node
longbowlu
requested review from
lxfind,
patrickkuo,
Bridgerz,
mwtian and
mystenmark
patrickkuo
pushed a commit
that referenced
this pull request
May 2, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
… starting bridge node (#16771) ## Description This PR does two things: 1. make `bridge_client_gas_object` in BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address. 2. add tests for starting bridge node. 3. move key generation helper functions to `crates/sui-bridge/src/utils.rs` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
bridge_client_gas_objectin BridgeConfig optional. If no gas object is provided, then we look for any gas object owned by the client address.crates/sui-bridge/src/utils.rsTest Plan
How did you test the new or updated feature?
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes