[Linter] 'loop' without exit #16875
Merged
[Linter] 'loop' without exit #16875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
tx-tomcat
force-pushed
the
custom_rules/empty_loop
branch
from
7b47b41
to
e84877b
Compare
|
@tx-tomcat is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
tx-tomcat
force-pushed
the
custom_rules/empty_loop
branch
from
e84877b
to
ba51d0a
Compare
tx-tomcat
force-pushed
the
custom_rules/empty_loop
branch
from
03c26f8
to
deb15c9
Compare
tnowacki
approved these changes
Sep 12, 2024
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
# Description - Gives a suspicious lint for loop without break or return. - Does not currently consider if that break or return is reachable ## Test plan - New tests ## Release notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [X] CLI: Move lint will now warn against `loop`s without `break` or `return` - [ ] Rust SDK: --------- Co-authored-by: jamedzung <[email protected]> Co-authored-by: Todd Nowacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
loops withoutbreakorreturn