[native-bridge] - add coins dynamically #16904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
longbowlu
approved these changes
Mar 30, 2024
patrickkuo
added a commit
that referenced
this pull request
May 2, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
May 8, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
## Description New APIs : `register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)` for registering new foreign token type New system message: added new `AddSuiToken` message for validators to approve new tokens addition to the bridge Notable changes: added BridgeTokenMetadata to treasury which contains token information Removed `notional_values` from bridge limiter, token value is now stored in the treasury in the `BridgeTokenMetadata` Removed bridged token packages (BTC, ETH, USDT, and USDC) from framework Added bridged tokens packages to `bridge/move/tokens` Added new token registration to `TestCluster` changed all static reference of token id and names with id_token_map obtained from `BridgeSummary` ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes --------- Co-authored-by: longbowlu <[email protected]> Co-authored-by: Dario Russi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New APIs :
register_foreign_token<T>(self: &mut Bridge, tc: TreasuryCap<T>, uc: UpgradeCap, metadata: &CoinMetadata<T>)for registering new foreign token type
New system message:
added new
AddSuiTokenmessage for validators to approve new tokens addition to the bridgeNotable changes:
added BridgeTokenMetadata to treasury which contains token information
Removed
notional_valuesfrom bridge limiter, token value is now stored in the treasury in theBridgeTokenMetadataRemoved bridged token packages (BTC, ETH, USDT, and USDC) from framework
Added bridged tokens packages to
bridge/move/tokensAdded new token registration to
TestClusterchanged all static reference of token id and names with id_token_map obtained from
BridgeSummaryTest Plan
How did you test the new or updated feature?
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes