[cli][easy] Add serialize-signed-transaction and serialize-unsigned transaction flags for sui client ptb command #16905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Looks good, thanks @stefan-mysten ! Left a comment that we can perhaps address later, to make client ptb even more consistent with other client commands.
| @@ -157,6 +164,17 @@ impl PTB { | |||
| program_metadata.gas_budget.value, | |||
| gas_price, | |||
| ); | |||
|
|
|||
| if program_metadata.serialize_unsigned_set { | |||
| serialize_or_execute!(tx_data, true, false, context, PTB).print(true); | |||
There was a problem hiding this comment.
Can we use serialize_or_execute to do more of what's happening below? (Execute the transaction and display it?) It seems like that would help with consistency in general.
There was a problem hiding this comment.
I think we can do that once we add the summary flag to other commands. Then I can probably have everything within this macro for PTB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
serialize-signed-transactionandserialize-unsigned-transactionflags that output transaction bytes instead of executing the transaction for thesui client ptbcommand.Test Plan
Existing tests as this uses the
serialize-or-executemacro.If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
Added support for the
serialize-signed-transactionandserialize-unsigned-transactionflags that output transaction bytes instead of executing the transaction for thesui client ptbcommand.