-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: level2 book status validation #16919
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this would fix the issue.
I am wondering how frequent prod fixes for Deepbook look from the outside? Would users or malicious players think the protocol has weaknesses?
@manolisliolios Do you have context on this? Curious as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The md change is autogen'd, so that part lgtm.
Description
Validation for get_level2_book_status_bid(ask)_side for price_low, price_high inputs.
Test Plan
How did you test the new or updated feature?
Testnet deepbook pool testing
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
Provides a more precise rounding calculation in Deepbook accessor function (read only) that returns level 2 book data within a price range.