-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature verification and add token message verification #16934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bridgerz
commented
Mar 28, 2024
- update signature verification to revert with duplicate, and invalid signatures instead of skipping.
- include verification of provided "Sui Decimals" in Add EVM Token message function.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bridgerz
force-pushed
the
token-price-type
branch
from
March 29, 2024 05:46
8c81591
to
05b091c
Compare
Bridgerz
requested review from
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat,
ronny-mysten,
mystenmark,
joyqvq,
kchalkias and
benr-ml
as code owners
March 29, 2024 05:46
Bridgerz
force-pushed
the
token-price-type
branch
from
March 29, 2024 17:03
05b091c
to
aa4ac4f
Compare
Bridgerz
requested review from
longbowlu
and removed request for
wlmyng and
stefan-mysten
March 29, 2024 21:18
longbowlu
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz rebase this to skip the token precision change
patrickkuo
pushed a commit
that referenced
this pull request
May 2, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
1. update signature verification to revert with duplicate, and invalid signatures instead of skipping. 2. include verification of provided "Sui Decimals" in Add EVM Token message function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.