Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature verification and add token message verification #16934

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

Bridgerz
Copy link
Contributor

  1. update signature verification to revert with duplicate, and invalid signatures instead of skipping.
  2. include verification of provided "Sui Decimals" in Add EVM Token message function.

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 10:01pm

@Bridgerz Bridgerz requested review from longbowlu and removed request for wlmyng and stefan-mysten March 29, 2024 21:18
Copy link
Contributor

@longbowlu longbowlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz rebase this to skip the token precision change

bridge/evm/test/BridgeConfigTest.t.sol Outdated Show resolved Hide resolved
bridge/evm/test/BridgeConfigTest.t.sol Show resolved Hide resolved
bridge/evm/test/BridgeConfigTest.t.sol Show resolved Hide resolved
bridge/evm/test/BridgeConfigTest.t.sol Show resolved Hide resolved
Base automatically changed from token-price-type to feature/native-bridge March 29, 2024 21:53
@Bridgerz Bridgerz merged commit 0d81be9 into feature/native-bridge Mar 29, 2024
48 checks passed
@Bridgerz Bridgerz deleted the audit-fixes branch March 29, 2024 22:23
patrickkuo pushed a commit that referenced this pull request May 2, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
patrickkuo pushed a commit that referenced this pull request May 8, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
patrickkuo pushed a commit that referenced this pull request May 9, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
patrickkuo pushed a commit that referenced this pull request May 9, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
patrickkuo pushed a commit that referenced this pull request May 9, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
patrickkuo pushed a commit that referenced this pull request May 9, 2024
1. update signature verification to revert with duplicate, and invalid
signatures instead of skipping.
2. include verification of provided "Sui Decimals" in Add EVM Token
message function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants