Check bridge routes on send token #16960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dariorussi
requested review from
patrickkuo,
damirka,
longbowlu,
Bridgerz and
manolisliolios
longbowlu
approved these changes
Mar 29, 2024
| @@ -93,6 +93,7 @@ module bridge::bridge { | |||
| const EBridgeAlreadyPaused: u64 = 13; | |||
| const EBridgeNotPaused: u64 = 14; | |||
| const ETokenAlreadyClaimed: u64 = 15; | |||
| const EInvalidBridgeRoute: u64 = 16; | |||
There was a problem hiding this comment.
just a headsup this will conflict with your other PRs
| @@ -175,6 +176,7 @@ module bridge::bridge { | |||
| ) { | |||
| let inner = load_inner_mut(self); | |||
| assert!(!inner.paused, EBridgeUnavailable); | |||
| assert!(chain_ids::is_valid_route(inner.chain_id, target_chain), EInvalidBridgeRoute); | |||
| fun test_execute_send_token_invalid_route() { | ||
| let mut scenario = test_scenario::begin(@0x0); | ||
| let ctx = test_scenario::ctx(&mut scenario); | ||
| let chain_id = chain_ids::sui_devnet(); |
There was a problem hiding this comment.
nit: use testnet(), since we are deprecating devnet id
dariorussi
force-pushed
the
bridge_audit3
branch
from
853c84e
to
07e2c95
Compare
patrickkuo
pushed a commit
that referenced
this pull request
May 2, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Audit found that `send_token` was not checking for valid routes. Added the missing check ## Test Plan Added unit tests. Positive tests (no abort) for `send_token` are a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests. --- If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Audit found that
send_tokenwas not checking for valid routes.Added the missing check
Test Plan
Added unit tests.
Positive tests (no abort) for
send_tokenare a bit trickier and will be added when unit test review is done. They were not there so this is not a regression in tests.If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes