[GraphQL] Remove "Live" ObjectKind, rename "Historical" to "Indexed" #17313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description
With the removal of direct accesses to the `objects` table, the
nomenclature we use around object kinds ("not indexed", "live",
"historical", "deleted or wrapped") is less relevant. In particular,
we never use "live" and the name "historical" is confusing because
even the latest version of the object may be considered "historical".
This PR removes the "live" kind, and renames "historical" to "indexed"
to better reflect how the users of GraphQL perceive the kinds of
objects, rather than how the data is stored in the indexer's tables.
## Test plan
```
sui$ cargo nextest run -p sui-graphql-rpc
sui$ cargo nextest run -p sui-graphql-e2e-tests --features pg_integration
```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Note that this PR is introducing a breaking change, so I will not be cherry-picking it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the removal of direct accesses to the
objectstable, the nomenclature we use around object kinds ("not indexed", "live", "historical", "deleted or wrapped") is less relevant. In particular, we never use "live" and the name "historical" is confusing because even the latest version of the object may be considered "historical".This PR removes the "live" kind, and renames "historical" to "indexed" to better reflect how the users of GraphQL perceive the kinds of objects, rather than how the data is stored in the indexer's tables.
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
LiveorHistoricalObjectKind. Instead, there is a singleIndexedkind representing any object that has been fetched from the index (as opposed to an object that we have information about but that hasn't been indexed yet, or an object that has been deleted or wrapped so is not available).