[cli] Add gas estimate feature #17322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
7 tasks
amnn
reviewed
Apr 25, 2024
github-actions
bot
added
the
Type: Documentation
Excellent. With this occasion, I also fixed a bug there and now the TS SDK implementation and this one match. |
amnn
reviewed
Apr 27, 2024
crates/sui/tests/snapshots/ptb_files_tests__assign_valid.ptb.snap
Outdated
Show resolved
Hide resolved
amnn
approved these changes
Apr 30, 2024
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 1, 2024
## Description This PR adds automatic gas estimation by dry running the transaction if the gas budget is not provided. That means that the `gas_budget` flag is now optional. ## Test plan Existing tests + new test ``` cd crates/sui && cargo test -- test_gas_estimation ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Added automatic gas estimation feature for the Sui CLI. If gas budget is not provided, the tool will dry run the transaction to get a gas budget estimate, and then it will execute the transaction. That means that for all relevant commands the `--gas-budget` flag is now optional. Please note that this incurs a small cost in performance due to the additional dry run call. - [ ] Rust SDK:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 1, 2024
## Description This PR adds automatic gas estimation by dry running the transaction if the gas budget is not provided. That means that the `gas_budget` flag is now optional. ## Test plan Existing tests + new test ``` cd crates/sui && cargo test -- test_gas_estimation ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Added automatic gas estimation feature for the Sui CLI. If gas budget is not provided, the tool will dry run the transaction to get a gas budget estimate, and then it will execute the transaction. That means that for all relevant commands the `--gas-budget` flag is now optional. Please note that this incurs a small cost in performance due to the additional dry run call. - [ ] Rust SDK:
stefan-mysten
added a commit
that referenced
this pull request
May 1, 2024
## Description Cherry picking feature into `releases/sui-v1.24.0-release` branch for the next release next week. This PR adds automatic gas estimation by dry running the transaction if the gas budget is not provided. That means that the `gas_budget` flag is now optional. ## Test plan Existing tests + new test ``` cd crates/sui && cargo test -- test_gas_estimation ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Added automatic gas estimation feature for the Sui CLI. If gas budget is not provided, the tool will dry run the transaction to get a gas budget estimate, and then it will execute the transaction. That means that for all relevant commands the `--gas-budget` flag is now optional. Please note that this incurs a small cost in performance due to the additional dry run call. - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds automatic gas estimation by dry running the transaction if the gas budget is not provided. That means that the
gas_budgetflag is now optional.Test plan
Existing tests + new test
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
--gas-budgetflag is now optional. Please note that this incurs a small cost in performance due to the additional dry run call.