[Other]Rename udo systemctl stop sui-node[201~ to udo systemctl stop sui-no… #17375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de[201~ I encountered an issue while cloning the repository in Windows, which seems to be caused by filenames in the repository not conforming to NTFS file system naming conventions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
@amnn Could you please help me check this change? It still troubles me |
|
Thanks for flagging @shaflow01, I think I know what's going on. I noticed that we had a Windows CI issue recently, and I think it's related to this. Fix coming soon. |
|
Thank you for your kindly reply.Waiting for it to be fixed |
amnn
added a commit
that referenced
this pull request
Apr 29, 2024
## Description A file was accidentally checked in that isn't compatible with Windows -- our Windows build CI is failing, and we also have reports from users that it's messing with their git checkouts on Windows. I don't think the file is supposed to be there, so let's remove it. Fixes #17375 ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
|
Landed the fix in |
ebmifa
pushed a commit
that referenced
this pull request
Apr 29, 2024
## Description A file was accidentally checked in that isn't compatible with Windows -- our Windows build CI is failing, and we also have reports from users that it's messing with their git checkouts on Windows. I don't think the file is supposed to be there, so let's remove it. Fixes #17375 ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
pushed a commit
to stefan-mysten/sui
that referenced
this pull request
May 17, 2024
## Description A file was accidentally checked in that isn't compatible with Windows -- our Windows build CI is failing, and we also have reports from users that it's messing with their git checkouts on Windows. I don't think the file is supposed to be there, so let's remove it. Fixes MystenLabs#17375 ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
pushed a commit
to stefan-mysten/sui
that referenced
this pull request
May 17, 2024
## Description A file was accidentally checked in that isn't compatible with Windows -- our Windows build CI is failing, and we also have reports from users that it's messing with their git checkouts on Windows. I don't think the file is supposed to be there, so let's remove it. Fixes MystenLabs#17375 ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
stefan-mysten
added a commit
that referenced
this pull request
May 17, 2024
## Description A file was accidentally checked in that isn't compatible with Windows -- our Windows build CI is failing, and we also have reports from users that it's messing with their git checkouts on Windows. I don't think the file is supposed to be there, so let's remove it. Fixes #17375 ## Test plan CI --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: Co-authored-by: Ashok Menon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered an issue while cloning the repository in Windows, which seems to be caused by filenames in the repository not conforming to NTFS file system naming conventions.
Test plan
Although it can be resolved by setting it through git config, renaming the files will be more convenient.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.