[std] Better ASCII methods + minor cleanup in std #17380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirka
requested review from
amnn,
tnowacki,
tzakian,
sblackshear,
leecchh,
manolisliolios,
dariorussi and
0xaslan
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
damirka
changed the title
leecchh
approved these changes
Apr 27, 2024
amnn
approved these changes
Apr 27, 2024
0xaslan
reviewed
Apr 28, 2024
0xaslan
reviewed
Apr 28, 2024
| assert!(b"AHELLOZ".to_ascii_string().is_alphanumeric(), 3); | ||
| assert!(b"0123".to_ascii_string().is_alphanumeric(), 4); | ||
| assert!(!b"!".to_ascii_string().is_alphanumeric(), 2); | ||
| assert!(!b" ".to_ascii_string().is_alphanumeric(), 1); |
0xaslan
approved these changes
Apr 28, 2024
jolestar
reviewed
Apr 28, 2024
There was a problem hiding this comment.
Do we provide an into_bytes(string: String): vector<u8> to string as the ascii?
There was a problem hiding this comment.
We do not, we only have std::string::bytes(string: &String): &vector<u8>, seems reasonable to have an into_bytes as well though!
There was a problem hiding this comment.
There is an into_bytes method in std::ascii already.
There was a problem hiding this comment.
Oh, my bad. You mean the std::string module. I'll add as a part of this PR!
damirka
force-pushed
the
ds/better-ascii-methods
branch
from
fa645d2
to
c638357
Compare
tnowacki
reviewed
Apr 30, 2024
|
|
||
| /// Copy the slice of the `string` from `i` to `j` into a new `String`. | ||
| public fun sub_string(string: &String, mut i: u64, j: u64): String { | ||
| assert!(i <= j && j <= string.length(), EInvalidIndex); |
There was a problem hiding this comment.
maybe split over multiple asserts for better line numbers with #[error] in the future
There was a problem hiding this comment.
I will do once we get to better error handling. I'd like to change the codes as well, so it's better done in a separate PR.
amnn
approved these changes
May 9, 2024
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
This reverts commit ab2bc7c.
patrickkuo
added a commit
that referenced
this pull request
May 9, 2024
…17613) This reverts commit ab2bc7c. ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
1 task
damirka
added a commit
that referenced
this pull request
Jun 29, 2024
## Description This PR rolls #17380 (successfully merged once) yet again. ## Test plan Features tests. ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: This change updates the [ascii module](https://docs.sui.io/references/framework/move-stdlib/ascii) in the following ways: Adds new methods to `std::ascii`: - `ascii::append(&mut String, String)` - `ascii::is_empty(): bool` - `ascii::substring(&String, i, j): String` - `ascii::index_of(&String, &String): u64` - `ascii::to_uppercase(&String): String` - `ascii::to_lowercase(&String): String` These additions make the ASCII interface more similar to the UTF8 one. Renames: - `string::bytes() to string::as_bytes()` - `string::sub_string() to string::substring()` Deprecates: - `string::sub_string` in favour of `string::substring` - `string::bytes` in favour of `string::as_bytes` Additional changes: - updates `std::type_name` to use `std::substring` - removes use statements for implicit imports - renames constants from `E_INDEX` to conventional `EIndexOutOfBounds`
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…s#18462) ## Description This PR rolls MystenLabs#17380 (successfully merged once) yet again. ## Test plan Features tests. ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [x] Protocol: This change updates the [ascii module](https://docs.sui.io/references/framework/move-stdlib/ascii) in the following ways: Adds new methods to `std::ascii`: - `ascii::append(&mut String, String)` - `ascii::is_empty(): bool` - `ascii::substring(&String, i, j): String` - `ascii::index_of(&String, &String): u64` - `ascii::to_uppercase(&String): String` - `ascii::to_lowercase(&String): String` These additions make the ASCII interface more similar to the UTF8 one. Renames: - `string::bytes() to string::as_bytes()` - `string::sub_string() to string::substring()` Deprecates: - `string::sub_string` in favour of `string::substring` - `string::bytes` in favour of `string::as_bytes` Additional changes: - updates `std::type_name` to use `std::substring` - removes use statements for implicit imports - renames constants from `E_INDEX` to conventional `EIndexOutOfBounds`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new methods to
std::ascii:ascii::append(&mut String, String)ascii::is_empty(): boolascii::substring(&String, i, j): Stringascii::index_of(&String, &String): u64ascii::to_uppercase(&String): Stringascii::to_lowercase(&String): StringSo ASCII interface is similar to the one in UTF8
Renames:
string::bytes() -> string::as_bytes()string::sub_string() -> string::substring()Additionally:
std::type_nameto usestd::substringE_INDEXto conventionalEIndexOutOfBoundsTest plan
Features tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Adds new methods to
std::ascii:ascii::append(&mut String, String)ascii::is_empty(): boolascii::substring(&String, i, j): Stringascii::index_of(&String, &String): u64ascii::to_uppercase(&String): Stringascii::to_lowercase(&String): StringThese additions make the ASCII interface more similar to the UTF8 one.
Renames:
string::bytes() to string::as_bytes()string::sub_string() to string::substring()Additional changes:
std::type_nameto usestd::substringE_INDEXto conventionalEIndexOutOfBounds