-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bridge] remove unnecessary &mut #17470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbowlu
requested review from
patrickkuo,
Bridgerz,
dariorussi and
Nikhil-Mysten
May 2, 2024 06:09
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
dariorussi
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
bridge: &mut Bridge, | ||
clock: &Clock, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
## Description 1. `get_token_transfer_action_signatures` and `get_token_transfer_action_status` does not need mutable Bridge ref 2. switch the order of Bridge and clock in `claim_token_internal` so we can use the receiver syntax ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description 1. `get_token_transfer_action_signatures` and `get_token_transfer_action_status` does not need mutable Bridge ref 2. switch the order of Bridge and clock in `claim_token_internal` so we can use the receiver syntax ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description 1. `get_token_transfer_action_signatures` and `get_token_transfer_action_status` does not need mutable Bridge ref 2. switch the order of Bridge and clock in `claim_token_internal` so we can use the receiver syntax ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description 1. `get_token_transfer_action_signatures` and `get_token_transfer_action_status` does not need mutable Bridge ref 2. switch the order of Bridge and clock in `claim_token_internal` so we can use the receiver syntax ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description 1. `get_token_transfer_action_signatures` and `get_token_transfer_action_status` does not need mutable Bridge ref 2. switch the order of Bridge and clock in `claim_token_internal` so we can use the receiver syntax ## Test plan existing tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_token_transfer_action_signatures
andget_token_transfer_action_status
does not need mutable Bridge refclaim_token_internal
so we can use the receiver syntaxTest plan
existing tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.