tests and move 2024 cleanup #17517
Merged
tests and move 2024 cleanup #17517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
longbowlu
reviewed
May 7, 2024
Comment on lines
87
to
95
| public(package) fun create(ctx: &TxContext): BridgeCommittee { | ||
| assert!(tx_context::sender(ctx) == @0x0, ENotSystemAddress); | ||
| BridgeCommittee { | ||
| members: vec_map::empty(), | ||
| member_registrations: vec_map::empty(), | ||
| last_committee_update_epoch: 0, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
do you want to do sth like
///////////////////////////////////////////
/// Public functions ///
///////////////////////////////////////////
to make it more readable and for future contributors?
There was a problem hiding this comment.
I really do not like that but I could add a public function group marker
| // Dupicate keys would cause `try_create_next_committee` to fail and, | ||
| // in consequence, an end of epoch transaction to fail (safe mode run). | ||
| // This check will ensure the creation of the committee is correct. | ||
| fun check_uniqueness_bridge_keys(self: &BridgeCommittee, bridge_pubkey_bytes: vector<u8>) { |
There was a problem hiding this comment.
do we have unit test for this?
There was a problem hiding this comment.
I do not think so and we are not yet 100% test coverage. So soon...
| scenario.end(); | ||
| destroy(treasury); | ||
| } | ||
| } |
| let mut bcs = bcs::new(input); | ||
| assert!(peel_u64_be(&mut bcs) == expected, 0) | ||
| #[test_only] | ||
| public(package) fun validator_eth_addresses(block_list: &Blocklist): &vector<vector<u8>> { |
There was a problem hiding this comment.
good call, I do not see usage so I will remove and see, thanks
| let mut bcs = bcs::new(input); | ||
| assert!(peel_u64_be_for_testing(&mut bcs) == expected, 0) | ||
| } | ||
| } |
Comment on lines
+72
to
+89
| public fun token_id<T>(self: &BridgeTreasury): u8 { | ||
| let metadata = self.get_token_metadata<T>(); | ||
| metadata.id | ||
| } | ||
|
|
||
| public fun decimal_multiplier<T>(self: &BridgeTreasury): u64 { | ||
| let metadata = self.get_token_metadata<T>(); | ||
| metadata.decimal_multiplier | ||
| } | ||
|
|
||
| public fun notional_value<T>(self: &BridgeTreasury): u64 { | ||
| let metadata = self.get_token_metadata<T>(); | ||
| metadata.notional_value | ||
| } |
There was a problem hiding this comment.
do these need to be public? It looks like people won't be able to get &BridgeTreasury anyway: https://github.com/MystenLabs/sui/blob/feature/native-bridge/crates/sui-framework/packages/bridge/sources/bridge.move#L674
There was a problem hiding this comment.
I think from the limiter? also they seemed accessors that are pretty harmless
|
feedback |
patrickkuo
approved these changes
May 8, 2024
patrickkuo
pushed a commit
that referenced
this pull request
May 8, 2024
## Description Mostly moved tests in their own files. Particularly tests that have to be expanded. Move 2024 cleanup. Formatting and convention alignment. This is almost no change except for few visibility changes we will talk about ## Test plan Existing test, no feature added --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Mostly moved tests in their own files. Particularly tests that have to be expanded. Move 2024 cleanup. Formatting and convention alignment. This is almost no change except for few visibility changes we will talk about ## Test plan Existing test, no feature added --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Mostly moved tests in their own files. Particularly tests that have to be expanded. Move 2024 cleanup. Formatting and convention alignment. This is almost no change except for few visibility changes we will talk about ## Test plan Existing test, no feature added --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Mostly moved tests in their own files. Particularly tests that have to be expanded. Move 2024 cleanup. Formatting and convention alignment. This is almost no change except for few visibility changes we will talk about ## Test plan Existing test, no feature added --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
patrickkuo
pushed a commit
that referenced
this pull request
May 9, 2024
## Description Mostly moved tests in their own files. Particularly tests that have to be expanded. Move 2024 cleanup. Formatting and convention alignment. This is almost no change except for few visibility changes we will talk about ## Test plan Existing test, no feature added --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly moved tests in their own files. Particularly tests that have to be expanded.
Move 2024 cleanup.
Formatting and convention alignment.
This is almost no change except for few visibility changes we will talk about
Test plan
Existing test, no feature added
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.