[GraphQL] Deprecate exchange rates + staking pool resolver #17577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_pool_id and exchange_rates_table resolver to fix previous issues
stefan-mysten
requested review from
amnn,
wlmyng,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
wlmyng
reviewed
May 8, 2024
That is correct. |
that's wild man |
wlmyng
approved these changes
May 8, 2024
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
May 8, 2024
Deprecates the ` exchange_rates` and `staking_pool` resolvers on validator type, and adds a `staking_pool_id` and `exchange_rates_table` resolver to correctly return the staking pool id and the wrapped exchange rates object. Existing tests: ``` cd sui-graphql-e2e-tests && cargo nextest run --features pg_integration ``` --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: Deprecated the ` exchange_rates` and `staking_pool` resolvers on validator type, and added a `staking_pool_id` and `exchange_rates_table` resolver to correctly return the staking pool id and the wrapped exchange rates object. - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the
exchange_ratesandstaking_poolresolvers on validator type, and adds astaking_pool_idandexchange_rates_tableresolver to correctly return the staking pool id and the wrapped exchange rates object.Test plan
Existing tests:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
exchange_ratesandstaking_poolresolvers on validator type, and added astaking_pool_idandexchange_rates_tableresolver to correctly return the staking pool ID and the wrapped exchange rates object.