[indexer] properly set key for cache in indexer reader #17649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
emmazzz
force-pushed
the
emma/fix-indexer-reader-cache
branch
from
3d752d1
to
625f30e
Compare
sadhansood
approved these changes
May 11, 2024
bmwill
approved these changes
May 11, 2024
emmazzz
added a commit
that referenced
this pull request
May 11, 2024
## Description
Right now we are setting the key of the cache to be the raw string `"{
format!("{}{}", package_id, obj_type) }"`, which does not change with
the input causing the cache to essentially store the first entry and
always returning it. This PR fixes that. I've scanned the code base and
changed the only two occurrences of `cache_get_or_set_with`
## Test plan
tested locally
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [x] Indexer:
- [x] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
emmazzz
added a commit
that referenced
this pull request
May 11, 2024
## Description
Right now we are setting the key of the cache to be the raw string `"{
format!("{}{}", package_id, obj_type) }"`, which does not change with
the input causing the cache to essentially store the first entry and
always returning it. This PR fixes that. I've scanned the code base and
changed the only two occurrences of `cache_get_or_set_with`
## Test plan
tested locally
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [x] Indexer:
- [x] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now we are setting the key of the cache to be the raw string
"{ format!("{}{}", package_id, obj_type) }", which does not change with the input causing the cache to essentially store the first entry and always returning it. This PR fixes that. I've scanned the code base and changed the only two occurrences ofcache_get_or_set_withTest plan
tested locally
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.