Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL/TransactionBlock] Scan Limits #18413

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Commits on Aug 20, 2024

  1. implement scan limit

    comments elucidating why we check the transaction's first or last cursor against the scan limited cursor of the current page
    
    do the same for the backwards pagination case
    
    when a cursor is specified, bump scan_limit by one so we don't count it among the txs scanned. otherwise we'll be short one
    wlmyng authored and amnn committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3221f34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7f22d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. fixup: more snapshots

    amnn committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    19254c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. fixup: use half-open intervals everywhere.

    There was a bug related to bounds for the first page, when it contains
    the genesis checkpoint. This was fixed by refactoring `TxBounds` to
    systematically use a half-open interval (inclusive lowerbounds and
    exclusive upperbounds) when calculating and combining intervals to be
    used on the DB, regardless of where the bounds came from and whether
    they were inclusive or exclusive at source.
    
    Also added a new test to exercise this behaviour -- all existing tests
    also pass, unchanged.
    amnn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9e8122e View commit details
    Browse the repository at this point in the history
  2. fixup: No more Page.scan_limit.

    amnn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4c4fff6 View commit details
    Browse the repository at this point in the history
  3. fixup: rustdoc no_run

    amnn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    336b1d5 View commit details
    Browse the repository at this point in the history
  4. fixup: rustdoc ignore

    amnn committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d6dbe27 View commit details
    Browse the repository at this point in the history