[cli] improve git output #18636
Merged
[cli] improve git output #18636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
@vegetabledogdog is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @vegetabledogdog! I think this is reasonable. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@tzakian what do you think? |
stefan-mysten
approved these changes
Sep 13, 2024
vegetabledogdog
force-pushed
the
cli
branch
from
e8886ee
to
2f796c2
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description
Check if git is installed.
Ouput the git clone or git fetch message
## Test plan
1. git is not installed
```
sui move build
Git is not installed or not in the PATH.
Failed to build Move modules: Failed to resolve dependencies for package 'gitt'
Caused by:
0: Fetching 'Sui'
1: Git is not installed or not in the PATH..
```
2.network error
```
sui move build
FETCHING GIT DEPENDENCY https://github.com/MystenLabs/sui.git
Cloning into '/home/sun/.move/https___github_com_MystenLabs_sui_git_framework__testnet'...
fatal: unable to access 'https://github.com/MystenLabs/sui.git/': Could not resolve host: github.com
Failed to build Move modules: Failed to resolve dependencies for package 'up'
Caused by:
0: Parsing manifest for 'Sui'
1: No such file or directory (os error 2).
```
3.Show the progress of git
```
sui move build
FETCHING GIT DEPENDENCY https://github.com/MystenLabs/sui.git
Cloning into '/home/sun/.move/https___github_com_MystenLabs_sui_git_framework__testnet'...
remote: Enumerating objects: 345462, done.
remote: Counting objects: 100% (5589/5589), done.
remote: Compressing objects: 100% (2204/2204), done.
Receiving objects: 9% (33800/345462), 35.71 MiB | 4.38 MiB/s
```
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [x] CLI: Improve error and status messages for `sui move build`.
- [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if git is installed.
Ouput the git clone or git fetch message
Test plan
2.network error
3.Show the progress of git
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui move build.