Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql): Align all e2e tests on protocol 51 #19402

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

amnn
Copy link
Member

@amnn amnn commented Sep 16, 2024

Description

Some of these tests are on older versions because they landed around the time of the last bump. Bringing everything in line with protocol 51.

Test plan

$ cargo nextest run -p sui-graphql-e2e-tests

Stack


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:38pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:38pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:38pm

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last protocol is 58/59, but I assume 51 works for now.

@amnn
Copy link
Member Author

amnn commented Sep 17, 2024

I'm just bringing all the tests in line at the same protocol version, not aiming to bump the protocol, which may introduce other unexpected changes.

@stefan-mysten
Copy link
Contributor

I'm just bringing all the tests in line at the same protocol version, not aiming to bump the protocol, which may introduce other unexpected changes.

👍

Base automatically changed from amnn/tx-affected-ci to main September 17, 2024 17:19
## Description

Some of these tests are on older versions because they landed around the
time of the last bump. Bringing everything in line with protocol 51.

## Test plan

```
$ cargo nextest run -p sui-graphql-e2e-tests
```
@amnn amnn force-pushed the amnn/gql-e2e-protocol-version branch from 09b977a to e6842ba Compare September 17, 2024 17:32
@amnn amnn merged commit e7b7740 into main Sep 17, 2024
46 of 48 checks passed
@amnn amnn deleted the amnn/gql-e2e-protocol-version branch September 17, 2024 18:01
amnn added a commit that referenced this pull request Sep 18, 2024
## Description

Add `TransactionBlockFilter.affectedAddress` as a way to filter
transactions by their relationship to an address without worrying about
what kind of relationship that is.

## Test plan

New E2E 

## Stack

- #19363
- #19371
- #19402 
- #19403

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants