Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] Remove version related routes #19410

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Sep 17, 2024

Description

Removes the version related routes.

Test plan

Existing tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL: GraphQL only supports one version instead of beta, stable, legacy. This change removes the previous routes and only allows for / and /graphql, which will always point to the latest version.
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 4:49am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 4:49am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 4:49am
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 4:49am

Copy link
Member

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefan-mysten !

@amnn
Copy link
Member

amnn commented Sep 17, 2024

Checked #19191 and indeed my mistake was that I only removed the extra routes in the service built during tests 😬 thanks for the clean up!

@stefan-mysten stefan-mysten merged commit a725da9 into MystenLabs:main Sep 17, 2024
45 of 46 checks passed
@stefan-mysten stefan-mysten deleted the gql_remove_routes branch September 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants