Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql)!: deprecate tx signer filters #19430

Merged
merged 4 commits into from
Sep 18, 2024
Merged

feat(graphql)!: deprecate tx signer filters #19430

merged 4 commits into from
Sep 18, 2024
+545 −28

Commits on Sep 18, 2024

  1. feat(graphql)!: deprecate tx signer filters 

    ## Description

`TransactionBlockFilter.signAddress` and
`AddressTransactionBlockFilter.SIGN` both claim to support filtering by
sender and sponsor, but this is not true, they only support sender, and
they should not be adapted to also filter by sponsor because we rely on
the there being only one sender per transaction to ensure filters that
combine sender with something else remain both space and time efficient.

## Test plan

Existing tests and CI, plus some new tests to make sure the new filter
options work, and interactions between the old and new filters work.

```
sui$ cargo nextest run -p sui-graphql-rpc
sui$ cargo nextest run -p sui-graphql-e2e-tests
```
    @amnn
    amnn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e8ba9b3 View commit details
    Browse the repository at this point in the history

  2. fixup: e2e tests for signer filter deprecation

    @amnn
    amnn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9cf76b6 View commit details
    Browse the repository at this point in the history

  3. Revert "fixup: sent -> signed" 

    This reverts commit f47be8b10a9801be261fc94b06bfd7e73179702d.
    @amnn
    amnn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a901655 View commit details
    Browse the repository at this point in the history

  4. fixup: copypasta

    @amnn
    amnn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    dce67b5 View commit details
    Browse the repository at this point in the history