[cli] Remove indexer feature for sui and remove the sui-pg binary
#19436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his indexer feature to build sui binary
stefan-mysten
requested review from
a team,
amnn,
wlmyng,
emmazzz,
suiwombat and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
github-actions
bot
added
the
Type: Documentation
|
|
stefan-mysten
force-pushed
the
cli_remove_indexer_feature
branch
from
85582d4
to
7dd4f2c
Compare
stefan-mysten
commented
Sep 18, 2024
| @@ -29,15 +29,19 @@ runs: | |||
| - name: cargo build | |||
| if: env.s3_file_exist == '' # if empty, we have not built and uploaded this binary to s3 yet | |||
| run: | | |||
| cargo build --bin sui --features indexer | |||
| if [[ "${{ inputs.ref }}" == 'devnet' || "${{ inputs.ref }}" == 'testnet' ]]; then | |||
There was a problem hiding this comment.
Note that this is a workaround until we get this code into devnet/testnet branches. When that happens, we need to remove this (a.k.a the workflow will fail anyway).
bmwill
approved these changes
Sep 19, 2024
ebmifa
pushed a commit
that referenced
this pull request
Sep 19, 2024
…#19436) ## Description Recent improvements on GraphQL and Postgres code removed the dynamic linking to `libpq`. Due to this linking (GH actions was linking to postgres@14), we had to have a separate `sui-pg` binary that was built with the `indexer` feature such that one can have access to `sui start --with-indexer` and `--with-graphql` due to the required dependencies to Postgres. This PR removes the `indexer` feature, all the instances of building the binary with `--features indexer` in workflows, actions, etc, and updates the documentation (docs + sui-test-validator crate). This is possible because `libpq` is no longer a dependency that gets dynamically linked to the binary. Note that in order to use those flags, a running Postgres DB is still required just like before. ## Test plan Existing tests. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: the `indexer` feature was removed from the `sui` crate as the dynamic linking to `libpq` was removed. Therefore, the `sui-pg` binary will not be part of releases anymore. This `sui-pg` binary was used for starting a network with `--with-indexer` and `--with-graphql` flags. These commands will still work as before and it is still required to have installed a Postgres database. If you used `sui-pg` binary previously, you can simply use `sui` binary from this version on. - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent improvements on GraphQL and Postgres code removed the dynamic linking to
libpq. Due to this linking (GH actions was linking to postgres@14), we had to have a separatesui-pgbinary that was built with theindexerfeature such that one can have access tosui start --with-indexerand--with-graphqldue to the required dependencies to Postgres.This PR removes the
indexerfeature, all the instances of building the binary with--features indexerin workflows, actions, etc, and updates the documentation (docs + sui-test-validator crate). This is possible becauselibpqis no longer a dependency that gets dynamically linked to the binary. Note that in order to use those flags, a running Postgres DB is still required just like before. If you used sui-pg binary previously, you can simply use sui binary from this version on.Test plan
Existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
indexerfeature was removed from thesuicrate as the dynamic linking tolibpqwas removed. Therefore, thesui-pgbinary will not be part of releases anymore. Thissui-pgbinary was used for starting a network with--with-indexerand--with-graphqlflags. These commands will still work as before and it is still required to have installed a Postgres database.If you used
sui-pgbinary previously, you can simply usesuibinary from this version on.