Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] Formatting: utils, object, tx_context, types, random 5/N #19498

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Sep 23, 2024

Description

Continues the formatting.

Test plan

Tests must pass, framework must be compatible.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 10:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 10:09pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 10:09pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 10:09pm

Comment on lines +1 to +5
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0

#[test_only]
module sui::display_tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be

Suggested change
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0
#[test_only]
module sui::display_tests {
// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0
#[test_only]
module sui::display_tests;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't touched tests yet! So this is intentional.

Comment on lines +4 to +5
#[test_only]
module sui::hex_tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Suggested change
#[test_only]
module sui::hex_tests {
#[test_only]
module sui::hex_tests;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@damirka damirka force-pushed the ds/formatting-sui-framework-utils branch from a653256 to da8ae94 Compare September 23, 2024 22:08
@damirka damirka merged commit 7336840 into main Sep 23, 2024
48 checks passed
@damirka damirka deleted the ds/formatting-sui-framework-utils branch September 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants