[GraphQL] Rework Event type #19654
[GraphQL] Rework Event type #19654
Conversation
stefan-mysten
requested review from
amnn,
wlmyng,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
1193a6e
to
f736cd3
Compare
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
f736cd3
to
b7462cc
Compare
stefan-mysten
changed the title
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
b7462cc
to
183a806
Compare
There was a problem hiding this comment.
Nice, thank you @stefan-mysten ! Could you also give a heads up to the SDK working group about this change and when it's expected to be released?
Definitely, thanks for the reminder! |
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
a40782a
to
7c56a58
Compare
|
|
.github/workflows/e2e.yml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| run: pnpm dlx concurrently --kill-others --success command-1 "$E2E_RUN_LOCAL_NET_CMD" 'pnpm --filter @mysten/sui test:e2e' | |||
|
|
|||
| - name: Run RPC/GrpahQL comaptability e2e tests | |||
| if: ${{ needs.diff.outputs.isGraphQlTransport == 'true' || needs.diff.outputs.isRust == 'true'}} | |||
| if: ${{ (needs.diff.outputs.isGraphQlTransport == 'true' || needs.diff.outputs.isRust == 'true') && github.ref == 'refs/heads/main' }} | |||
There was a problem hiding this comment.
this will also disable this on all PRs right?
There was a problem hiding this comment.
we probably still want this for PRs, but just against localnet
There was a problem hiding this comment.
I pushed another commit that checks specifically for devnet and testnet branches. I think that should work, what do you think? @hayes-mysten
There was a problem hiding this comment.
I am not very familiar with the github workflow syntax, but seems reasonable to me!
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
d550611
to
21f5269
Compare
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
a651b36
to
f134dcc
Compare
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
f134dcc
to
c5f22da
Compare
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
c5f22da
to
6dc335b
Compare
This reverts commit f780402.
This reverts commit f780402.
This reverts commit d7b708d.
Description
Accessing the
bcsfield of anEventis rather confusing, as it is not the whole event BCS encoded, but just the contents of it, more specifically, the BCS bytes of aMoveValue.This PR removes the #flatten in
Event, adds acontentsfield to the type, and adds thebcsfield to theEventtype which encodes the wholeEvent.Test plan
Existing tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Eventtype has a new field calledcontents, which is the event's content value as aMoveValue. This replaces the previous scheme that flattened theMoveValuetype in theEventtype. Abcsfield was also added, which represents the Base64 encoded BCS serialized event.