[consensus] Update proposer metrics #19655
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
All of the changes to the metrics can be seen reflected on the left side of the graphs and the right side is "main". Let me know what you think.
|
| .add_blocks(accepted_blocks.iter().map(|b| b.reference()).collect()) | ||
| // Get max round of accepted blocks. This will be equal to the threshold | ||
| // clock round, either by advancing the threshold clock round by being | ||
| // greater than current clock round or by equaling the current clock round. |
There was a problem hiding this comment.
Is this the case? Blocks older than current threshold clock round can get accepted as well.
There was a problem hiding this comment.
I only added the case in the comment for greater and equal but blocks less than the clock round are essentially ignored by threshold clock
| self.context | ||
| .metrics | ||
| .node_metrics | ||
| .block_proposal_leader_wait_count |
There was a problem hiding this comment.
I think we should use a separate metric for counting the number of times leader is not found. block_proposal_leader_wait_count is tied to block_proposal_leader_wait_ms, so when the average wait is ~250ms, we know the leader is missing.
There was a problem hiding this comment.
I think the confusion for me with these metrics is that it doesn't just include leader wait time, it includes the quorum receive wait time which can make this metric a little misleading. Separating them brings more clarity. Though I guess we could always subtract this metric from quorum receive latency.
Description
Adding a few metrics that will help with the smart ancestor selection investigations
block_proposal_leader_wait_msmetric valuesblock_proposal_leader_wait_countwhenever we hit the case where leaders don't exist during proposalTest plan
private-testnet
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.