Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add banners #19658

Merged
merged 5 commits into from
Oct 2, 2024
Merged

add banners #19658

merged 5 commits into from
Oct 2, 2024

Conversation

plam-ml
Copy link
Contributor

@plam-ml plam-ml commented Oct 2, 2024

Description

Add USDC Banner

usdc-banner-ext

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@plam-ml plam-ml requested a review from a team as a code owner October 2, 2024 17:04
@plam-ml plam-ml requested review from mystieanwaya and teaonsui and removed request for a team October 2, 2024 17:04
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Skipped (Inspect) Oct 2, 2024 7:13pm
sui-kiosk ⬜️ Skipped (Inspect) Oct 2, 2024 7:13pm
sui-typescript-docs ⬜️ Skipped (Inspect) Oct 2, 2024 7:13pm

@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs October 2, 2024 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit October 2, 2024 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk October 2, 2024 17:05 Inactive
Copy link
Contributor

@williamrobertson13 williamrobertson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks purty good as long as we've tested the overrides + banner with the flags on/off 😄

@vercel vercel bot temporarily deployed to Preview – sui-typescript-docs October 2, 2024 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – multisig-toolkit October 2, 2024 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-kiosk October 2, 2024 19:11 Inactive
@plam-ml plam-ml merged commit 14b89bd into main Oct 2, 2024
48 checks passed
@plam-ml plam-ml deleted the APPS-384 branch October 2, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants