-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mvr] use mvr-mode on sui-mvr-graphql-rpc for in-crate tests #20318
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
and to double check, this will not affect JSON RPC's object related endpoints, right?
It might affect |
yeah as this change is for mvr-mode only, would be good to minimize changes to other reading paths. |
ac24f00
to
92760b8
Compare
Description
Needed to adjust the
ConnectionAsObjectStore
, becauseobjects
will not be written to inmvr-mode
. Queryingobjects
and queryingobjects_history
+objects_snapshot
should both yield the live object set.Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.