Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade narwhal pointer #4316

Merged
merged 5 commits into from
Aug 30, 2022
Merged

chore: upgrade narwhal pointer #4316

merged 5 commits into from
Aug 30, 2022

Conversation

arun-koshy
Copy link
Contributor

@arun-koshy arun-koshy commented Aug 26, 2022 •
edited
Loading

contains changes

  • update new worker cache from config -> full details here
  • ed25519-dalek is "almost" fully removed -> (few dangling libraries that reference ed25519-dalek that @joyqvq will remove in a followup PR)

@huitseeker huitseeker mentioned this pull request Aug 29, 2022
Merged
@joyqvq joyqvq mentioned this pull request Aug 29, 2022
Closed
huitseeker
huitseeker approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • arrangement on tweaking fastcrypto version + ed25519 leftovers in a further PR LGTM (if it's ok with @JOY),
  • please announce as breaking change, since this will force a re-genesis.

@arun-koshy arun-koshy merged commit 31ce002 into main Aug 30, 2022
@arun-koshy arun-koshy deleted the workersplit branch August 30, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@tharbert tharbert Awaiting requested review from tharbert tharbert is a code owner

@Clay-Mysten Clay-Mysten Awaiting requested review from Clay-Mysten

@randall-Mysten randall-Mysten Awaiting requested review from randall-Mysten

@joyqvq joyqvq Awaiting requested review from joyqvq joyqvq is a code owner

@punwai punwai Awaiting requested review from punwai

@mystenmark mystenmark Awaiting requested review from mystenmark

@lxfind lxfind Awaiting requested review from lxfind

@asonnino asonnino Awaiting requested review from asonnino

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arun-koshy @huitseeker