Support USB HID media control keys now common on remotes and keyboards. #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While here, also map emacs-like Ctrl+B and Ctrl+F for rewind and fast foward as on older MCE remotes like ARC-1100. This required moving "jump to start" from Ctrl+B to Ctrl+A. Menu, Info and Delete are also mapped to the control keys of the colored ARC-1100 buttons. (cherry picked from commit 9133feb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears that USB HID standardized common media control keys some years after MythTV was invented. These have Keysyms in X11 and then Qt for several years now but it wasn't until 2019 and later that web browsers finally started supporting these keys.
So rather than all users manually mapping these, seems MythTV should support them out of the box. Home Page makes a great Info button on the MX3 but might be in an odd place on other remotes. But if this key is anywhere and makes it to MythTV it might as well do something useful, right? All others are hopefully self explanatory.
While here, also map emacs-like Ctrl+B and Ctrl+F for rewind and fast foward as on older MCE remotes like ARC-1100. This required moving "jump to start" from Ctrl+B to Ctrl+A. Menu, Info and Delete are also mapped to the control keys of the colored ARC-1100 buttons.
I assume this might have no effect on current installs if they keep the bindings as-is in the database. I don't have a way to test currently. But at least this should get the keys working on new installs.
Checklist